Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoryBook: Add Story for ResolutionTool #68292

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

im3dabasia
Copy link
Contributor

Part of #67165

What?

This PR adds Storybook stories for the ResolutionTool component to improve component documentation and testability.

Testing Instructions

  1. Run npm run storybook:dev
  2. Open Storybook at http://localhost:50240/
  3. Verify the following stories are present and functioning:
  4. Default rendering of the ResolutionTool component.

Screenshots or screencast

Screen.Recording.2024-12-25.at.4.43.47.PM.mov

@im3dabasia im3dabasia marked this pull request as ready for review December 26, 2024 16:20
@im3dabasia im3dabasia requested a review from ellatrix as a code owner December 26, 2024 16:20
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@im3dabasia im3dabasia force-pushed the storybook/resolution-control branch from d15debe to 17c114a Compare December 26, 2024 16:38
@im3dabasia
Copy link
Contributor Author

Hey @t-hamano ,

Please review my PR when you have a moment and provide me with your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant